Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gds-api-adapters from 88.2.0 to 89.0.0 #1877

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 20, 2023

Bumps gds-api-adapters from 88.2.0 to 89.0.0.

Changelog

Sourced from gds-api-adapters's changelog.

89.0.0

  • BREAKING: Change source for GdsApi.worldwide.world_locations method and remove pagination.
  • Change source for GdsApi.worldwide.world_location method (the response is backwards compatible).
Commits
  • ade2e5f Merge pull request #1203 from alphagov/update-world-method
  • 608e8c0 Merge pull request #1202 from alphagov/add-govuk_request_id-to-logs
  • 1ab0e84 Release version 89.0.0
  • 921942f Change source for GdsApi.worldwide.world_locations method
  • ca6aa61 Change source for GdsApi.worldwide.world_location method
  • 427398d Add govuk_request_id to logs when available
  • ea01cd9 Merge pull request #1201 from alphagov/dependabot/bundler/rubocop-govuk-eq-4....
  • 9a0c412 Update rubocop-govuk requirement from = 4.10.0 to = 4.11.0
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [gds-api-adapters](https://github.com/alphagov/gds-api-adapters) from 88.2.0 to 89.0.0.
- [Changelog](https://github.com/alphagov/gds-api-adapters/blob/main/CHANGELOG.md)
- [Commits](alphagov/gds-api-adapters@v88.2.0...v89.0.0)

---
updated-dependencies:
- dependency-name: gds-api-adapters
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jul 20, 2023
@github-actions
Copy link

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@FelixMarcusMillne
Copy link
Contributor

FelixMarcusMillne commented Jul 24, 2023

There is an issue with sorting that was introduced - needs to be fixed before merging

Issue is being tracked here: https://trello.com/c/eKjf7gPC/748-resolve-issue-with-world-location-sorting-in-gds-api-adapters

We should be waiting till at least versions above 89.0.0

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 1, 2023

Superseded by #1885.

@dependabot dependabot bot closed this Aug 1, 2023
@dependabot dependabot bot deleted the dependabot/bundler/gds-api-adapters-89.0.0 branch August 1, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies DO NOT MERGE ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant