348 migrate to dart sass #2278
348 migrate to dart sass #2278
Conversation
davidtrussler
force-pushed
the
348_Migrate-to-DartSass
branch
from
e3bf18f
to
3e2aaa6
Compare
There was a problem hiding this comment.
Kevin has commented on the govuk-docker PR on a better way of running the app, but that will involve some changes to this PR as well. I'm going to see if I can get that working locally.
There was a problem hiding this comment.
We're also going to need to make some similar fixes as were made to Content Tagger to resolve issues with some icons not appearing/appearing corrupted.
davidtrussler
force-pushed
the
348_Migrate-to-DartSass
branch
from
3e2aaa6
to
f4696c3
Compare
I have updated |
Ah right, good spot. This seems to be fixed by referencing the Glyphicons font in the legacy-application sass file. |
Hello @mtaylorgds - this has been addressed but needs to be marked as such before I am able to merge. Could you have a quick look? Cheers 🙂 |
- Initial installation - Configuration - Add builds folder - Update the manifest file - Add an initializer - Delete unused Sass configuration - Configure build options - Replace asset helpers - Update permissions for `bin/dev` - Update `Procfile.dev` to include the worker process - Add Glyphicons to legacy CSS file
davidtrussler
force-pushed
the
348_Migrate-to-DartSass
branch
from
94b768a
to
cff87b6
Compare
Trello
This work makes the necessary changes to migrate Publisher to use Dart Sass. It follows the instructions in Migrate to Dart Sass from LibSass.
It is close to the changes made in PR2250 (Switch from sassc-rails to dartsass-rails) with a couple of slight changes that seem to fix the issues encountered there, specifically bringing the legacy styles into the SASS Builds folder via the initialiser that is created as part of the work.