Update doc to explain 'Why is this being added directly to the Signon' #2279
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtaylorgds
reviewed
Aug 13, 2024
docs/homepage.md
Outdated
| @@ -23,6 +23,12 @@ We do not store the secrets generated by this command and just rely on the secre | |||
|
|
|||
| ### Questions | |||
|
|
|||
| #### Why is this being added directly to the Signon landing page and via Publisher? | |||
There was a problem hiding this comment.
Should this be "not via Publisher"?
There was a problem hiding this comment.
I meant to add and 'permissions via Publisher' but I think it has already been adressed so I will just keep it as Chris asked i.e. "Why is this being added directly to the Signon?"
docs/homepage.md
Outdated
| #### Why is this being added directly to the Signon landing page and via Publisher? | ||
|
|
||
| The functionality itself will sit within Mainstream Publisher. However, we’ve made the decision to take an experimental approach and show the Homepage link within the main signon page. | ||
| We’ve decided to trial this as we believe that users should simply be able to select what action they want to perform, rather than having to understand what app they need to use to accomplish a task. |
There was a problem hiding this comment.
If we want these to be separate paragraphs, I think we need to add a blank line in the source code, otherwise they will all be rendered as a single paragraph.
There was a problem hiding this comment.
keeping it as one paragraph
syed-ali-tw
force-pushed
the
update-popular-links-doc
branch
from
22677d0
to
c54c18e
Compare
syed-ali-tw
force-pushed
the
update-popular-links-doc
branch
from
c54c18e
to
2e1cd26
Compare
mtaylorgds
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update popular links doc to answer why Homepage is being added directly to the Signon landing page
Follow these steps if you are doing a Rails upgrade.