Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'More Details' summary contents width #2313

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ellohez
Copy link
Contributor

@ellohez ellohez commented Sep 6, 2024

Updated sass allows the contents of the 'More Details' summary section to spread out across all table columns.
Previously, this content was squashed into the first column which made it difficult to read.
More work may be done on this in future but this functionality is needed for user testing.
See Trello Card - Increase width of 'more details' section of the table [Publication Page]

Before the change:
image

After the change:
Screenshot 2024-09-05 at 15 47 02

Allow contents of details component summary to spread across all columns
Copy link
Contributor

@davidtrussler davidtrussler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Nice! 👍

Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; would be nice to have some before & after screenshots in the PR comment though.

@ellohez ellohez merged commit ff72ea4 into main Sep 6, 2024
14 checks passed
@ellohez ellohez deleted the increase-publication-table-width branch September 6, 2024 10:11
@ellohez
Copy link
Contributor Author

ellohez commented Sep 6, 2024

LGTM; would be nice to have some before & after screenshots in the PR comment though.

Added! Let me know if anything else is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants