This repository has been archived by the owner on Feb 12, 2020. It is now read-only.
settings reset (temporary solution) #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solution to enabling reset of settings to allow testing to continue
Pull Request Test Coverage Report for Build 2873
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 2873
💛 - Coveralls |
kirlat
approved these changes
May 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kirlat Monica is having trouble testing on Firefox because she moved the toolbar out of the view and Firefox doesn't seem to give any way for a user to request a reset of sync storage for an extension. I've tried all things and it seems it can only be done programmatically. I've entered alpheios-project/webextension#217 to make sure we clean up after ourselves upon uninstall, and #488 to allow for the user to choose to reset their settings themselves.
I didn't want to implement this at all until we can refactor the settings to use the vuex store, but I need to get Monica unstuck, so this is just a partial solution to allow her to initiate a reset. I tried but couldn't find a quick way to get all of the settings Vue components to redraw. This definitely isn't sufficient for production but at least will allow her to continue testing on FF.