Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding YouTube in a collaborative session doesn't seem to work #49

Open
inquam opened this issue Feb 7, 2024 · 6 comments
Open

Embedding YouTube in a collaborative session doesn't seem to work #49

inquam opened this issue Feb 7, 2024 · 6 comments
Labels
support Support user's cases(community driven)

Comments

@inquam
Copy link

inquam commented Feb 7, 2024

I have managed to get things up and running behind Traefik 2.
I run the main application on excalidraw.mydomain.com, the storage backend is replying to excalidraw.mydomain.com/storagehandler/... (to quickly get around CORS I have Traefik enforcing) and the rooms are running on excalidrawrooms.mydomain.com, since that didn't seem to like being on a path under the main domain.

I can collaborate, paste images that are stored correctly to the storage backend and shown to the collaborators etc.

But if I take a YouTube URL and paste it I get a never ending flow of

image

If I'm not in a collaborative session this does not happen and the preview shows up fine.

@alswl
Copy link
Owner

alswl commented Feb 8, 2024

Can you try the same actions in the official excalidraw (https://excalidraw.com/) and give more informations.

@alswl alswl added the question Further information is requested label Feb 8, 2024
@inquam
Copy link
Author

inquam commented Feb 13, 2024

On excalidraw.com it seems to work just fine.

I could perhaps open up for you to use my excalidraw install so you could start a shared session and try to embed for instance a YouTube url and see what happens? Not sure if private messages is possible on github so I could give you the url to access it on?

Also, an option to whitelist more URL's to allow embedding from would be nice. Seems to be handled here in the application excalidraw/excalidraw#6917. I have tried looking in the container for the excalidraw source code to try and simply edit it but I actually can't find it :)

@inquam
Copy link
Author

inquam commented Feb 13, 2024

What happens on my installation is that a GET request is made to the storage container to api/v2/rooms/0c61b6ff46f3f9db55fb with status 200.

Then that is immediately followed by a PUT request to the same url /api/v2/rooms/0c61b6ff46f3f9db55fb with status 200 which is directly followed by a request to YouTube for the embedded video (almost like it runs the code to embed it again) which makes everything flicker.

Then a few seconds go by and the same thing repeats itself. This goes on for ever or until you select and delete the embedded video.

image

@alswl
Copy link
Owner

alswl commented Feb 15, 2024

You can try this demo site ( https://excalidraw-production-4d27.up.railway.app/ ), the demo site is construct from this repo.

I think your problem is related to the deployed configuration, not the white sites list.

@alswl alswl added support Support user's cases(community driven) and removed question Further information is requested labels Feb 15, 2024
@inquam
Copy link
Author

inquam commented Feb 15, 2024

I got "Application failed to respond" from that URL.

@alswl
Copy link
Owner

alswl commented Feb 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Support user's cases(community driven)
Projects
None yet
Development

No branches or pull requests

2 participants