Better errors #294
Better errors #294
Conversation
Que3216
commented
Jul 17, 2023
•
Que3216
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with app url. Last updated for commit ce50df6. This comment will update as new commits are pushed. |
|
🤖 Meticulous replayed 1 user sessions and took 8 screenshots. Meticulous did not run on main of the main branch and so there was nothing to compare against. Please merge your pull request for setting up Meticulous in CI and ensure that it’s running on push events to the main branch. Test suite: test Meticulous with deployment url. Last updated for commit ce50df6. This comment will update as new commits are pushed. |
…n into qsh/better-errors
src/utils/workflow.utils.ts
Outdated
| const logger = log.getLogger(METICULOUS_LOGGER_NAME); | ||
| if ( | ||
| (err as { message?: string } | null)?.message?.includes( | ||
| "Workflow does not have 'workflow_dispatch' trigger" |
There was a problem hiding this comment.
The error returned is a 422 returned by GH servers (https://github.com/octokit/request-error.js/blob/372097e9b16f70d4ad75089003dc9154e304faa7/src/index.ts#L16):
RequestError [HttpError]: Workflow does not have 'workflow_dispatch' trigger
at /app/node_modules/@octokit/request/dist-node/index.js:86:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async $1e5661a16c61ad2e$export$e6c4ffd711240397 (file:///app/dist/index.mjs:291:5)
at async $9bad9e90aadb16eb$export$fe64d28a00d9670b (file:///app/dist/index.mjs:474:25)
at async $9bad9e90aadb16eb$export$246429c52b3b3bd3 (file:///app/dist/index.mjs:367:16)
at async $73105851ee1dace6$export$4196946125a2d37f (file:///app/dist/index.mjs:1029:59) {
status: 422,
response: {
url: <redacted>
status: 422,
...
It has no more precise error code than that, so have to use the message unfortunately. If they change this message it'll just fall through to the more general case below, so not the end of the world.
| @@ -33,3 +33,5 @@ export const setLogLevel: (logLevel: string | undefined) => void = ( | |||
| break; | |||
| } | |||
| }; | |||
|
|
|||
| export const shortSha = (sha: string) => sha.slice(0, 7); | |||
There was a problem hiding this comment.
Somewhat duplicative with the logic in our monorepo (source). Is it worth moving to the sdk or too small?
There was a problem hiding this comment.
I think too small to be worth it
Co-authored-by: Daniel Book <36259973+dbook13@users.noreply.github.com>
