Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional ports to be passed to proxy #433

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

edoardopirovano
Copy link
Contributor

This might be needed in a debugging session later today.

@edoardopirovano edoardopirovano requested a review from a team April 15, 2024 09:55
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
report-diffs-action ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 10:17am

Copy link

alwaysmeticulous bot commented Apr 15, 2024

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Test suite: public-tests. Last updated for commit 19168af. This comment will update as new commits are pushed.

Copy link

github-actions bot commented Apr 15, 2024

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Test suite: test Meticulous with deployment url. Last updated for commit 19168af. This comment will update as new commits are pushed.

Copy link

github-actions bot commented Apr 15, 2024

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Test suite: test Meticulous with app url. Last updated for commit 19168af. This comment will update as new commits are pushed.

Copy link
Contributor

@dbook13 dbook13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding a debug option to check-connecion.ts that tries to connect to all provided ports?

@edoardopirovano
Copy link
Contributor Author

Is it worth adding a debug option to check-connecion.ts that tries to connect to all provided ports?

Hmm, maybe, but I'm not sure what kind of request we'd make. For the app URL we know it should respond to a GET HTTP request because it's serving a webpage but it's not so obvious for the other ports.

I suggest we wait until we have a concrete case for this.

@edoardopirovano edoardopirovano merged commit dafc045 into main Apr 16, 2024
8 checks passed
@edoardopirovano edoardopirovano deleted the edoardo/additional-ports branch April 16, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants