-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional ports to be passed to proxy #433
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: public-tests. Last updated for commit 19168af. This comment will update as new commits are pushed. |
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with deployment url. Last updated for commit 19168af. This comment will update as new commits are pushed. |
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with app url. Last updated for commit 19168af. This comment will update as new commits are pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding a debug option to check-connecion.ts that tries to connect to all provided ports?
Hmm, maybe, but I'm not sure what kind of request we'd make. For the app URL we know it should respond to a GET HTTP request because it's serving a webpage but it's not so obvious for the other ports. I suggest we wait until we have a concrete case for this. |
This might be needed in a debugging session later today.