-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding of head commit #441
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Expected differences? Click here. Test suite: public-tests. Last updated for commit b040c7f. This comment will update as new commits are pushed. |
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with deployment url. Last updated for commit b040c7f. This comment will update as new commits are pushed. |
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with app url. Last updated for commit b040c7f. This comment will update as new commits are pushed. |
3a82d16
to
8e68af4
Compare
action.yml
Outdated
@@ -60,6 +60,14 @@ inputs: | |||
additional-ports: | |||
description: Ports the client needs to access the application in addition to the one in the app URL, as a list of comma-separated values | |||
required: false | |||
base-sha: | |||
description: | | |||
The base commit SHA to compare against. This can usually be inferred automatically by Meticulous, so typically you do not need to set this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it might be worth mentioning that this will override the sha inferred by Meticulous. The description kind of makes it seem like this input is a fallback if the sha can't be inferred.
30e21b2
to
b040c7f
Compare
As discussed, this would unblock Floww and potentially other future customers who have an unorthodox setup where we can't automatically infer these SHAs correctly.