Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of head commit #441

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

edoardopirovano
Copy link
Contributor

As discussed, this would unblock Floww and potentially other future customers who have an unorthodox setup where we can't automatically infer these SHAs correctly.

@edoardopirovano edoardopirovano requested a review from a team May 8, 2024 16:55
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
report-diffs-action ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:42pm

Copy link

alwaysmeticulous bot commented May 8, 2024

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Expected differences? Click here. Test suite: public-tests. Last updated for commit b040c7f. This comment will update as new commits are pushed.

Copy link

github-actions bot commented May 8, 2024

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Test suite: test Meticulous with deployment url. Last updated for commit b040c7f. This comment will update as new commits are pushed.

Copy link

github-actions bot commented May 8, 2024

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Test suite: test Meticulous with app url. Last updated for commit b040c7f. This comment will update as new commits are pushed.

action.yml Outdated
@@ -60,6 +60,14 @@ inputs:
additional-ports:
description: Ports the client needs to access the application in addition to the one in the app URL, as a list of comma-separated values
required: false
base-sha:
description: |
The base commit SHA to compare against. This can usually be inferred automatically by Meticulous, so typically you do not need to set this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it might be worth mentioning that this will override the sha inferred by Meticulous. The description kind of makes it seem like this input is a fallback if the sha can't be inferred.

@edoardopirovano edoardopirovano changed the title Allow overriding of base and head commits Allow overriding of head commit May 9, 2024
@edoardopirovano edoardopirovano merged commit f5fbb9c into main May 9, 2024
8 checks passed
@edoardopirovano edoardopirovano deleted the edoardo/sha-override branch May 9, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants