Use BE endpoint for calculating base in cloud-compute action #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Expected differences? Click here. Test suite: public-tests. Last updated for commit 67a7878. This comment will update as new commits are pushed. |
This fixes a bug where the head SHA provided as input was ignored in the cloud compute action. Additionally, this extends the action to deal with cases where the head of the PR commit is being tested, rather than the temporary merge commit. Previously we used the temp merge commit as a head commit sha regardless of what was being checked out.
alexivanov
force-pushed
the
fix-head-commit-sha-cloud-compute
branch
from
396f7fc
to
6cf58f3
Compare
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with deployment url. Last updated for commit 67a7878. This comment will update as new commits are pushed. |
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with app url. Last updated for commit 67a7878. This comment will update as new commits are pushed. |
edoardopirovano
approved these changes
Jun 5, 2024
alexivanov
changed the title
edoardopirovano
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the base commit calculation to use a BE endpoint instead of doing it within the action. This aligns us
The logic within the "old" action is kept as is as to maintain ability to use without installing the GH app.
This also drops the 'head sha' parameter from the old action. It's not currently used and it's usage is incorrect.