Handle deployment locking correctly #507
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Expected differences? Click here. Test suite: public-tests. Last updated for commit 40ecf4c. This comment will update as new commits are pushed. |
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with deployment url. Last updated for commit 40ecf4c. This comment will update as new commits are pushed. |
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with app url. Last updated for commit 40ecf4c. This comment will update as new commits are pushed. |
edoardopirovano
force-pushed
the
edoardo/deployment-locking
branch
from
e98653d
to
196920a
Compare
edoardopirovano
force-pushed
the
edoardo/deployment-locking
branch
from
196920a
to
40ecf4c
Compare
| "The test run has completed but additional tasks on the Meticulous platform are using this deployment, please keep this job running..." | ||
| ); | ||
| }; | ||
|
|
||
| const onTestRunCreated = (testRun: TestRun) => { | ||
| logger.info(`Test run created: ${testRun.url}`); | ||
| }; |
There was a problem hiding this comment.
So executeRemoteTestRun will hold off from returning until the lock is released?
There was a problem hiding this comment.
That's right, and periodically call onTunnelStillLocked above so that we log something.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
After this we should be able to lock
cloud-computetest runs which unblocks doing main branch session selection for most projects.