Merge pull request #29 from amcintosh/issue-28-lines-quantity-float

🐛 Update quantity on invoice lines to float
amcintosh · Mar 5, 2022 · 4b8260e · 4b8260e
2 parents dbafed9 + b2c27f1
commit 4b8260e
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Support for items
 - Support for tasks
+- Change quantity field on invoice lines and items to float
 
 ## 0.3.0
 

diff --git a/src/Model/Item.php b/src/Model/Item.php
@@ -61,7 +61,7 @@ class Item extends DataTransferObject implements DataModel
      */
     #[MapFrom('qty')]
     #[MapTo('qty')]
-    public ?int $quantity;
+    public ?float $quantity;
 
     /**
      * @var string Id for a specific item or product, used in inventory management.

diff --git a/src/Model/LineItem.php b/src/Model/LineItem.php
@@ -67,7 +67,7 @@ class LineItem extends DataTransferObject implements DataModel
      */
     #[MapFrom('qty')]
     #[MapTo('qty')]
-    public ?int $quantity;
+    public ?float $quantity;
 
     /**
      * @var string First tax amount, in percentage, up to 3 decimal places.

diff --git a/tests/Model/InvoiceTest.php b/tests/Model/InvoiceTest.php
@@ -263,7 +263,7 @@ public function testInvoiceFromResponse(): void
         $this->assertSame('Melmac melamine resin molded dinnerware', $line->description);
         $this->assertSame(0, $line->expenseId);
         $this->assertSame('Bowls', $line->name);
-        $this->assertSame(4, $line->quantity);
+        $this->assertSame(4.0, $line->quantity);
         $this->assertSame('13', $line->taxAmount1);
         $this->assertSame('0', $line->taxAmount2);
         $this->assertSame('HST1', $line->taxName1);
@@ -317,7 +317,7 @@ public function testInvoiceGetContent(): void
                     'description' => 'Melmac melamine resin molded dinnerware',
                     'expenseid' => 0,
                     'name' => 'Bowls',
-                    'qty' => 4,
+                    'qty' => 4.0,
                     'taxAmount1' => '13',
                     'taxAmount2' => '0',
                     'taxName1' => 'HST1',
@@ -339,7 +339,7 @@ public function testInvoiceGetContent(): void
                     'description' => 'Melmac melamine resin molded mug',
                     'expenseid' => 0,
                     'name' => 'Mugs',
-                    'qty' => 6,
+                    'qty' => 6.0,
                     'taxAmount1' => '0',
                     'taxAmount2' => '0',
                     'taxName1' => '',
@@ -411,7 +411,7 @@ public function testInvoiceGetContentNew(): void
                     'description' => 'Melmac melamine resin molded dinnerware',
                     'expenseid' => 0,
                     'name' => 'Bowls',
-                    'qty' => 4,
+                    'qty' => 4.0,
                     'taxAmount1' => '13',
                     'taxAmount2' => '0',
                     'taxName1' => 'HST1',
@@ -433,7 +433,7 @@ public function testInvoiceGetContentNew(): void
                     'description' => 'Melmac melamine resin molded mug',
                     'expenseid' => 0,
                     'name' => 'Mugs',
-                    'qty' => 6,
+                    'qty' => 6.0,
                     'taxAmount1' => '0',
                     'taxAmount2' => '0',
                     'taxName1' => '',

diff --git a/tests/Model/ItemTest.php b/tests/Model/ItemTest.php
@@ -44,7 +44,7 @@ public function testItemFromResponse(): void
         $this->assertSame('Melmac melamine resin molded dinnerware', $item->description);
         $this->assertSame('50', $item->inventory);
         $this->assertSame('Bowls', $item->name);
-        $this->assertSame(4, $item->quantity);
+        $this->assertSame(4.0, $item->quantity);
         $this->assertSame('SQ8608333', $item->sku);
         $this->assertSame(2, $item->tax1);
         $this->assertSame(0, $item->tax2);
@@ -62,7 +62,7 @@ public function testItemGetContent(): void
             'description' => 'Melmac melamine resin molded dinnerware',
             'inventory' => '50',
             'name' => 'Bowls',
-            'qty' => 4,
+            'qty' => 4.0,
             'sku' => 'SQ8608333',
             'tax1' => 2,
             'tax2' => 0,