fix: handle close errors

aminueza · Jul 10, 2024 · a6c38b3 · a6c38b3
1 parent ffc2e18
commit a6c38b3
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/minio/data_source_minio_s3_object.go b/minio/data_source_minio_s3_object.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"io"
+	"log"
 	"strconv"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
@@ -127,7 +128,12 @@ func dataSourceMinioS3ObjectRead(ctx context.Context, d *schema.ResourceData, me
 	if err != nil {
 		return diag.FromErr(fmt.Errorf("error reading object: %w", err))
 	}
-	defer object.Close()
+	defer func() {
+		err := object.Close()
+		if err != nil {
+			log.Printf("[WARN] Error closing S3 object source (%s): %s", objectName, err)
+		}
+	}()
 
 	objectInfo, err := object.Stat()
 	if err != nil {