Skip to content

Commit

Permalink
fix: use the id property instead of name for read ilm tier (#579)
Browse files Browse the repository at this point in the history
Also, replace `docker-compose` with `docker compose` (This is needed due to a change in Docker Compose CLI).

Co-authored-by: Victor Nogueira <felladrin@gmail.com>
  • Loading branch information
s-vitaliy and felladrin committed Aug 12, 2024
1 parent c2eeaf9 commit b060c12
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ jobs:
with:
version: "2023.1.6"
install-go: false
- name: Build the docker-compose stack
run: docker-compose up -d minio secondminio thirdminio fourthminio
- name: Build the Docker Compose stack
run: docker compose up -d minio secondminio thirdminio fourthminio
- uses: hashicorp/setup-terraform@v2
with:
terraform_version: 1.5.7
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ variable "minio_password" {
For testing locally, run the docker compose to spin up a minio server:

```sh
docker-compose up
docker compose up
```

Access `http://localhost:8000` on your browser, apply your terraform templates and watch them going live.
Expand Down
2 changes: 1 addition & 1 deletion minio/resource_minio_ilm_tier.go
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ func minioCreateILMTier(ctx context.Context, d *schema.ResourceData, meta interf

func minioReadILMTier(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
c := meta.(*S3MinioClient).S3Admin
name := d.Get("name").(string)
name := d.Id()
tier, err := getTier(c, ctx, name)
if err != nil {
return NewResourceError("reading remote tier failed", name, err)
Expand Down

0 comments on commit b060c12

Please sign in to comment.