add support for remote tier and ILM transition #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this addition, @s2thudry! And congrats on your first contribution to this repo! 🎉 |
felladrin
approved these changes
Jun 14, 2024
szinn
pushed a commit
to szinn/k8s-homelab
that referenced
this pull request
Jun 14, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://github.com/aminueza/terraform-provider-minio)) | required_provider | minor | `2.2.1` -> `2.3.0` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.3.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v2.3.0) [Compare Source](https://github.com/aminueza/terraform-provider-minio/compare/v2.2.1...v2.3.0) #### What's Changed - Add support for remote tier and ILM transition by [@​s2thudry](https://github.com/s2thudry) in [aminueza/terraform-provider-minio#565 #### New Contributors - [@​s2thudry](https://github.com/s2thudry) made their first contribution in [aminueza/terraform-provider-minio#565 **Full Changelog**: aminueza/terraform-provider-minio@v2.2.1...v2.3.0 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MDguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQwOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
kireque
pushed a commit
to kireque/home-ops
that referenced
this pull request
Jun 14, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://github.com/aminueza/terraform-provider-minio)) | required_provider | minor | `2.2.1` -> `2.3.0` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.3.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v2.3.0) [Compare Source](https://github.com/aminueza/terraform-provider-minio/compare/v2.2.1...v2.3.0) #### What's Changed - Add support for remote tier and ILM transition by [@​s2thudry](https://github.com/s2thudry) in [aminueza/terraform-provider-minio#565 #### New Contributors - [@​s2thudry](https://github.com/s2thudry) made their first contribution in [aminueza/terraform-provider-minio#565 **Full Changelog**: aminueza/terraform-provider-minio@v2.2.1...v2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MDguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQwOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL21pbm9yIl19--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for remote tier and ILM transition
This PR implements the following changes:
minio_ilm_tierminio_ilm_policyThis was only tested locally with multiple MinIO, I haven't tested with Azure, GCP or AWS.
This is my first time working with a Terraform provider so don't hesitate to tell me if some things are not done the proper way.
Regarding the sensitives values, it seems that madmin only return "REDACTED" so I added a parameter to for the edit of credential if set and ignore the constant diff between what madmin return and the actual sensitive value, let me know if this is ok for you or if you'd prefer I handle it differently.
Reference
Closing issues