Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Azure and GCP remote tier creation and add support for tier options #566

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

s2thudry
Copy link
Contributor

@s2thudry s2thudry commented Jun 19, 2024

Fix Azure and GCP remote tier creation

This PR implements the following changes:

  • fix Azure and GCP remote tier creation and add support for tier options

What existing problem does the pull request solve?

  • Fix Azure remote tier creation: the account name was not used properly and prevented the creation
  • Fix GCP remote tier creation: providing the credentials json made the provider crash
  • Support all remote tier options like region, storage class and prefix: previously theses were read but not created

Theses changes were tested with Azure and GCP sadly I don't have access to an AWS account to try out the changes.

@s2thudry s2thudry marked this pull request as ready for review June 19, 2024 14:49
Copy link
Collaborator

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
Will be released along in v2.3.1.

@felladrin felladrin merged commit 4885c6a into aminueza:main Jun 20, 2024
2 checks passed
kireque pushed a commit to kireque/home-ops that referenced this pull request Jun 20, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://github.com/aminueza/terraform-provider-minio)) |
required_provider | patch | `2.3.0` -> `2.3.1` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v2.3.1`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v2.3.1)

[Compare
Source](https://github.com/aminueza/terraform-provider-minio/compare/v2.3.0...v2.3.1)

#### What's Changed

- Fix Azure and GCP remote tier creation and add support for tier
options by [@&#8203;s2thudry](https://github.com/s2thudry) in
[aminueza/terraform-provider-minio#566
- Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[aminueza/terraform-provider-minio#567
- Bump golang.org/x/net from 0.17.0 to 0.23.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[aminueza/terraform-provider-minio#568

**Full Changelog**:
aminueza/terraform-provider-minio@v2.3.0...v2.3.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Jun 22, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://github.com/aminueza/terraform-provider-minio)) |
required_provider | patch | `2.3.0` -> `2.3.2` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v2.3.2`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v2.3.2)

[Compare
Source](https://github.com/aminueza/terraform-provider-minio/compare/v2.3.1...v2.3.2)

#### What's Changed

- Fix: Handle case when IAM Policy was deleted externally by
[@&#8203;s-vitaliy](https://github.com/s-vitaliy) in
[aminueza/terraform-provider-minio#569

#### New Contributors

- [@&#8203;s-vitaliy](https://github.com/s-vitaliy) made their first
contribution in
[aminueza/terraform-provider-minio#569

**Full Changelog**:
aminueza/terraform-provider-minio@v2.3.1...v2.3.2

###
[`v2.3.1`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v2.3.1)

[Compare
Source](https://github.com/aminueza/terraform-provider-minio/compare/v2.3.0...v2.3.1)

#### What's Changed

- Fix Azure and GCP remote tier creation and add support for tier
options by [@&#8203;s2thudry](https://github.com/s2thudry) in
[aminueza/terraform-provider-minio#566
- Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[aminueza/terraform-provider-minio#567
- Bump golang.org/x/net from 0.17.0 to 0.23.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[aminueza/terraform-provider-minio#568

**Full Changelog**:
aminueza/terraform-provider-minio@v2.3.0...v2.3.1

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants