Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add the endpoint property to Amazon S3 config #571

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Jul 9, 2024

This PR implements the following changes:

  • Pass the endpoint argument to the MinIo client if the S3 tier is being used.

Reference

Resolves #570

People

@george-zubrienko, FYI

Closing issues

Copy link
Collaborator

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see more contributions coming in! 🎉

@felladrin felladrin merged commit 0e71b68 into aminueza:main Jul 10, 2024
2 checks passed
@s-vitaliy s-vitaliy deleted the endpoint-amazon-s3-config branch July 11, 2024 08:26
kireque pushed a commit to kireque/home-ops that referenced this pull request Jul 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://github.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `2.3.2` -> `2.4.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v2.4.0`](https://github.com/aminueza/terraform-provider-minio/releases/tag/v2.4.0)

[Compare
Source](https://github.com/aminueza/terraform-provider-minio/compare/v2.3.2...v2.4.0)

#### What's Changed

- fix: Add the endpoint property to Amazon S3 config by
[@&#8203;s-vitaliy](https://github.com/s-vitaliy) in
[aminueza/terraform-provider-minio#571
- feat: add minio_s3\_object data source by
[@&#8203;lorenzofelletti](https://github.com/lorenzofelletti) in
[aminueza/terraform-provider-minio#572
- docs: more extensive docs by
[@&#8203;lorenzofelletti](https://github.com/lorenzofelletti) in
[aminueza/terraform-provider-minio#573

#### New Contributors

- [@&#8203;lorenzofelletti](https://github.com/lorenzofelletti) made
their first contribution in
[aminueza/terraform-provider-minio#572

**Full Changelog**:
aminueza/terraform-provider-minio@v2.3.2...v2.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL21pbm9yIl19-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint is not saved for ILM tier when using S3 config
2 participants