Skip to content

Commit

Permalink
Remove old github environment values
Browse files Browse the repository at this point in the history
  • Loading branch information
ammaraskar committed Feb 16, 2020
1 parent df6eece commit 8b4f601
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
4 changes: 1 addition & 3 deletions sphinx_action/action.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
from sphinx_action import status_check


GithubEnvironment = collections.namedtuple(
"GithubEnvironment", ["sha", "repo", "token", "build_command"]
)
GithubEnvironment = collections.namedtuple("GithubEnvironment", ["build_command"])


def extract_line_information(line_information):
Expand Down
14 changes: 2 additions & 12 deletions tests/test_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,7 @@ def test_build_docs_with_different_makefile(self):

def test_build_all_docs_success(self):
action.build_all_docs(
action.GithubEnvironment(
sha="sha1hash",
repo="ammaraskar/sphinx-action",
token="SecretToken1",
build_command="make html",
),
action.GithubEnvironment(build_command="make html",),
[
os.path.join(TEST_PROJECTS_DIR, "no_errors"),
os.path.join(TEST_PROJECTS_DIR, "warnings"),
Expand All @@ -127,12 +122,7 @@ def test_build_all_docs_success(self):
def test_build_all_docs_some_success(self):
with self.assertRaisesRegex(RuntimeError, "Build failed"):
action.build_all_docs(
action.GithubEnvironment(
sha="sha1hash",
repo="ammaraskar/sphinx-action",
token="SecretToken1",
build_command="make html",
),
action.GithubEnvironment(build_command="make html",),
[
os.path.join(TEST_PROJECTS_DIR, "no_errors"),
os.path.join(TEST_PROJECTS_DIR, "warnings_and_errors"),
Expand Down

0 comments on commit 8b4f601

Please sign in to comment.