Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: XCode 14 fixes - update iPhone targets to 11, MacOS to 10.15, appledoc #442

Merged
merged 2 commits into from
May 30, 2023
Merged

fix: XCode 14 fixes - update iPhone targets to 11, MacOS to 10.15, appledoc #442

merged 2 commits into from
May 30, 2023

Conversation

justin-fiedler
Copy link
Contributor

@justin-fiedler justin-fiedler commented May 30, 2023 •
edited
Loading

Summary

  • Update iOS and macOS target to versions supported by Github (iPhone 11, OSX 10.15)
  • Fix error with appledoc and XCode 14.1. Created and switched to a new fork that includes a workaround amplitude/appledoc

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@justin-fiedler justin-fiedler changed the title fix: update iPhone targets to 11, MacOS to 10.15 fix: XCode 14 fixes - update iPhone targets to 11, MacOS to 10.15, appledoc May 30, 2023
@justin-fiedler justin-fiedler merged commit 5c15979 into main May 30, 2023
@justin-fiedler justin-fiedler deleted the AMP-76888-fix-ios-release branch May 30, 2023 21:26
github-actions bot pushed a commit that referenced this pull request May 30, 2023
@amplitude-sdk-bot
chore(release): 8.16.1 [skip ci]
b951260 
## [8.16.1](v8.16.0...v8.16.1) (2023-05-30)

### Bug Fixes

* set _inForeground value earlier ([#433](#433)) ([3cee4c2](3cee4c2))
* sudo rm appledoc ([#444](#444)) ([53ba490](53ba490))
* XCode 14 fixes - update iPhone targets to 11, MacOS to 10.15, appledoc ([#442](#442)) ([5c15979](5c15979))
@github-actions
Copy link

🎉 This PR is included in version 8.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhao900914 yuhao900914 yuhao900914 approved these changes

@falconandy falconandy Awaiting requested review from falconandy

@Mercy811 Mercy811 Awaiting requested review from Mercy811

@bgiori bgiori Awaiting requested review from bgiori

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin-fiedler @yuhao900914