Support detection of Chrome binaries #3136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stijn Taelemans <taelemansst@gmail.com>
Signed-off-by: Stijn Taelemans <taelemansst@gmail.com>
lem-onade
force-pushed
the
feat/support-chrome-binary-version-detection
branch
from
d238549
to
880f5db
Compare
|
@kzantow, any chance you could review/merge this when you have a moment? Thanks! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds results for chrome binaries, tested with v126 linux64 and v127 linux64 binaries inside a local dir
tested with ppodgorsek/robot-framework, installs chrome binary using
npx @puppeteer/browsers install chrome@VERSIONin Dockerfiletested with browserless/chrome (chrome 121) -- detects binary