Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record state after timestamp update #588

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: record state after timestamp update #588

merged 1 commit into from
May 24, 2024

Conversation

asomya
Copy link
Contributor

@asomya asomya commented May 24, 2024

fixing a bug where state was not recorded after updating timestamp

@wagoodman wagoodman added the bug Something isn't working label May 24, 2024
@asomya asomya force-pushed the ENTERPRISE-3944 branch 2 times, most recently from cfe5e93 to 5caa11d Compare May 24, 2024 15:18
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is still a need to change _update (+ test) to consider not only count > 0 but also stale (probably stale or count > 0)

@asomya asomya force-pushed the ENTERPRISE-3944 branch 2 times, most recently from 7009c53 to e8fd992 Compare May 24, 2024 15:44
@svietry
Copy link

svietry commented May 24, 2024

Is there a unit test that can be added for this case?
@asomya

@wagoodman wagoodman added the run-pr-quality-gate Triggers running of quality gate on PRs label May 24, 2024
fixing a bug where state was not recorded after updating timestamp

Signed-off-by: Arvind Somya <arvind.somya@anchore.com>
@wagoodman wagoodman merged commit 012417f into main May 24, 2024
10 checks passed
@wagoodman wagoodman deleted the ENTERPRISE-3944 branch May 24, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run-pr-quality-gate Triggers running of quality gate on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants