Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The crash connected with PhotoView library #16

Closed
cryser29 opened this issue Oct 25, 2017 · 1 comment
Closed

The crash connected with PhotoView library #16

cryser29 opened this issue Oct 25, 2017 · 1 comment
Assignees
Labels

Comments

@cryser29
Copy link

Thank you for the great library!

Context

I don't use PhotoView separately but received following crash report:

Fatal Exception: java.lang.IllegalArgumentException: pointerIndex out of range
       at android.view.MotionEvent.nativeGetAxisValue(MotionEvent.java)
       at android.view.MotionEvent.getX(MotionEvent.java:2372)
       at android.support.v4.view.ViewPager.onInterceptTouchEvent(ViewPager.java:2064)

I found following resolved issues of PhotoView library that are connected with the crash above #31 and #293. The author of PhotoView described the solution of this problem.

Possible Fix

Replace android.support.v4.view.ViewPager in activity_preview.xml with HackyViewPager.

Thank you!

@andremion
Copy link
Owner

Thank you @cryser29 for your tip! 👏🏻
If you prefer, you can open a PR with the solution so I can review it and later merge it. 😎

Suggestion

Put the HackyViewPager code into com.andremion.louvre.util package 😉

Thanks!

@andremion andremion added the bug label Oct 26, 2017
@andremion andremion self-assigned this Nov 15, 2017
andremion added a commit that referenced this issue Nov 15, 2017
Fixing of issue #16 - IllegalArgumentException: pointerIndex out of range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants