Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluralise MyModel for Screen and ViewModel #53

Open
wants to merge 1 commit into
base: base
Choose a base branch
from
Open

Pluralise MyModel for Screen and ViewModel #53

wants to merge 1 commit into from

Conversation

dturner
Copy link

@dturner dturner commented Dec 16, 2022

The existing MyModelScreen actually shows a list of MyModels rather than a single MyModel. This PR pluralises the Screen and ViewModel class names to more accurately describe what the UI is doing.

@JoseAlcerreca
Copy link
Contributor

Have you checked all remaining instances of MyModel ? I guess some of them must stay singular. Did you take that into account in the script?

@dturner
Copy link
Author

dturner commented Jan 4, 2023

The objects which don't need renaming are MyModelRepository, MyModelDao, MyModel and the test classes associated with these objects. These have not been renamed as part of this PR.

Did I miss something?

Also, if/when this is merged we should update the multimodule branch with these changes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseAlcerreca JoseAlcerreca Awaiting requested review from JoseAlcerreca

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dturner @JoseAlcerreca