-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace testharness with DeviceConfigurationOverride
#1221
Replace testharness with DeviceConfigurationOverride
#1221
Conversation
Because `accompanist/testharness` is deprecated. ref: https://google.github.io/accompanist/testharness/
DeviceConfigurationOverride
DeviceConfigurationOverride
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment on the version, and it looks like CI is failing. Do the tests pass locally for you?
- rename `androidxUiTest` to `androidxComposeUiTest` - update version
I have no idea what causes the
Is it due to dependence? |
It seems like the #1220 will update our Compose dependencies from |
Hi @sanao1006, many thanks for submitting this PR. Unfortunately I already had a branch with this change in it ready to go (plus some slight cosmetic differences e.g. version catalog naming) so I will merge this PR instead when we're ready. |
I do have some questions/comments on @alexvanyo's comment though:
Could you elaborate more on this? Why doesn't
Yes, it does resolve the issue. Would you consider this behaviour a bug? It certainly seems like one if you can add a library and have compilation fail in an non-obvious way. |
This has come up before such as in android/android-test#1315 (comment) This definitely feels buggy - it's not clear at all why the version is "fixed" to the one in the main source set instead of being bumped by the one in the test source set. We should follow-up with AGP folks to use this as an example of whether this behavior can be improved. |
Hi @dturner
I understand. Thanks for contacting me! It is OK to close this PR when your discussion is complete! |
Closing this PR - #1140 has more info about the resolution restrictions as reference. |
What I have done and why
Replace testharness with
DeviceConfigurationOverride
.This is because
accompanist/testharness
is deprecated.ref: https://google.github.io/accompanist/testharness/
Fixes #1201