Retry reading default GCP credentials in the expired case #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liutikas
force-pushed
the
betterretries
branch
2 times, most recently
from
884bfcb
to
639bf44
Compare
rnakade
reviewed
Jul 26, 2023
gcpbuildcache/src/main/kotlin/androidx/build/gradle/gcpbuildcache/GcpStorageService.kt
Outdated
Show resolved
Hide resolved
Currently, Google Auth library caches default credentials indefinitely in a static field. This means if user's credentials expire, they run gcloud auth command, then try runnning Gradle again the old credentials are used. This change adds a reflection based mechanism to clear default credentials cache and retrying one additional time to get new credentials. Additionally, allow specifying the message on authentication failure.
rnakade
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Google Auth library caches default credentials indefinitely in a static field. This means if user's credentials expire, they run gcloud auth command, then try runnning Gradle again the old credentials are used. This change adds a reflection based mechanism to clear default credentials cache and retrying one additional time to get new credentials.
Additionally, allow specifying the message on authentication failure.