Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R-devel (4.1.x) error due to all.equal change #26

Closed
andybega opened this issue Dec 10, 2020 · 0 comments
Closed

R-devel (4.1.x) error due to all.equal change #26

andybega opened this issue Dec 10, 2020 · 0 comments

Comments

@andybega
Copy link
Owner

  • all.equal() will compare environments
  • testthat 2e expect_equal() uses all.equal() at some point
  • there is one test for plot_missing that now fails because environments are not equal

The solution is to add a single check.environment = FALSE.

(Note to self: see email from Martin Maechler on 2020-12-09.)

Fix coming up shortly.
andybega added a commit that referenced this issue Apr 14, 2021
@andybega
move to testthat 3e (see #26)
3dcd7aa 
this should also fix the all.equal(..., check.environments = TRUE) thing coming up in R 4.1
@andybega andybega closed this as completed Sep 5, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andybega