Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding typescript definition file #34

Closed
wants to merge 1 commit into from
Closed

Adding typescript definition file #34

wants to merge 1 commit into from

Conversation

sstorie
Copy link

@sstorie sstorie commented Oct 31, 2015

Adding the typescript definition file to the package. Based on this
discussion: #32.

Adding the typescript definition file to the package. Based on this
discussion: #32.
@sstorie
Copy link
Author

sstorie commented Oct 31, 2015

I'm trying to confirm this, but I thought at the recent AngularConnect conference there was a typescript talk saying that newer versions of TS will automatically look in npm packages for d.ts files. Including this file in the package would let typescript automatically find the definition file.

@sstorie
Copy link
Author

sstorie commented Oct 31, 2015

Actually, this may not work using the /// <reference=... link because the redux definition file isn't in the npm package for redux. That path was based on using DefinitelyTyped, so might need to include the Redux types directly.

@sstorie sstorie closed this Nov 1, 2015
@sstorie
Copy link
Author

sstorie commented Nov 1, 2015

Sorry, this just isn't right so I'm gonna re-submit with the proper changes. Sorry for any confusion this creates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant