Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular/build): support custom postcss config #28352

Closed
wants to merge 1 commit into from

Conversation

BBboy01
Copy link

@BBboy01 BBboy01 commented Sep 5, 2024

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

allow user define custom postcss configure from legacy json configure file type postcss.config.json and .postcssrc.json

Issue Number: N/A

What is the new behavior?

use modern js type postcss configure file type

Does this PR introduce a breaking change?

  • Yes
  • No

json type configure file can never be used, but this part is not include in doc, so may not is breaking changes.

Other information

Close #27819

Copy link

google-cla bot commented Sep 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: @angular/build labels Sep 5, 2024
@BBboy01
Copy link
Author

BBboy01 commented Sep 5, 2024

json file type has no reference of postcss plugins, and no lsp supports, js is prettey better way to use as configure file

and the early migration guide still recommand to use js

if we realy want to contain every file type of postcss configure, i prefer to use postcss-load-config

@alan-agius4
Copy link
Collaborator

Closing as CLA has not been signed.

@BBboy01
Copy link
Author

BBboy01 commented Sep 13, 2024

@alan-agius4 sorry about the CLA, I'm not noticed the detail of robot comment, now the CLA check is passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: @angular/build detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS support for PostCSS config
2 participants