Skip to content

Commit

Permalink
fix(multiple): change fallbacks to use m3 (#29528)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewseguin committed Aug 21, 2024
1 parent 9323bf4 commit cb1450f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
8 changes: 8 additions & 0 deletions src/material/core/_core.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@

// Mixin that renders all of the core styles that are not theme-dependent.
@mixin core() {
// TODO: Move ripple styles to be dynamically loaded instead of in core.
// This variable is used as a fallback for the ripple element's
// background color. However, if it isn't defined anywhere, then MSS
// complains in its verification stage.
html {
--mat-app-on-surface: initial;
}

@include ripple.ripple();
@include cdk.a11y-visually-hidden();
@include cdk.overlay();
Expand Down
6 changes: 1 addition & 5 deletions src/material/core/tokens/_token-utils.scss
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,7 @@ $_system-fallbacks: m3-tokens.create-system-fallbacks();
@return _create-var($sys-fallback, $fallback);
}

// TODO(mat-app-theme): Return the system-level fallback.
// Changing this will affect clients that do not properly call theme mixins since the tokens
// will be undefined and now default to M3 system values, causing a number of screenshot failures.
// @return $sys-fallback;
@return $fallback;
@return $sys-fallback;
}

// Outputs a map of tokens under a specific prefix.
Expand Down

0 comments on commit cb1450f

Please sign in to comment.