feat(material/radio): add the ability to interact with disabled radio buttons #29490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
G
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
commented
Jul 26, 2024
| @@ -466,6 +466,19 @@ describe('MDC-based MatCheckbox', () => { | |||
| expect(inputElement.disabled).toBe(false); | |||
| })); | |||
|
|
|||
| it('should not change the checked state if disabled and interactive', fakeAsync(() => { | |||
There was a problem hiding this comment.
This is unrelated to the radio button, but I realized that I forgot to include it in #29474.
| // The real click event will bubble up, and the generated click event also tries to bubble up. | ||
| // This will lead to multiple click events. | ||
| // Preventing bubbling for the second event will solve that issue. | ||
| event.stopPropagation(); |
There was a problem hiding this comment.
I removed this because it turned out that before this change we were never actually calling the _onInputClick callback. It must've gotten lost during the MDC transition.
… buttons Adds the `disabledInteractive` input that allows users to opt into being able to interact with a disabled radio button (e.g. focus or show a tooltip). Also fixes that we weren't setting `pointer-events: none` on the entire container when it's disabled.
crisbeto
force-pushed
the
radio-disabled-interactive
branch
from
b8182a9
to
b389b04
Compare
andrewseguin
approved these changes
Jul 26, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
disabledInteractiveinput that allows users to opt into being able to interact with a disabled radio button (e.g. focus or show a tooltip).Also fixes that we weren't setting
pointer-events: noneon the entire container when it's disabled.