feat(cdk/a11y): use native media query for high contrast detection #29678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the `cdk.high-contrast` mixin to use a native media query instead of a custom CSS classes. The advantage is that we no longer need to depend on the `HighContrastModeDetector` to add a class that we can target. BREAKING CHANGE: * Since `cdk.high-contrast` targets a media query instead of a class, the specificity of the styles it emits is lower than before.
crisbeto
added
Accessibility
crisbeto
requested review from
amysorto and
wagnermaciel
and removed request for
a team
angular-robot
bot
added
detected: breaking change
devversion
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
cdk.high-contrastmixin to use a native media query instead of a custom CSS classes. The advantage is that we no longer need to depend on theHighContrastModeDetectorto add a class that we can target.BREAKING CHANGE:
cdk.high-contrasttargets a media query instead of a class, the specificity of the styles it emits is lower than before.