Skip to content

Commit

Permalink
ci: fixed found issue with the new ci
Browse files Browse the repository at this point in the history
  • Loading branch information
prisis committed Jul 22, 2024
1 parent 8735187 commit aeb4a3c
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 2 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dist
README.md

.github/ISSUE_TEMPLATE
.github/CONTRIBUTING.md

verify-node-version.cjs

Expand Down
7 changes: 7 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ module.exports = defineConfig({
"no-underscore-dangle": "off",
},
},
{
files: ["**/*.yml"],
rules: {
// @TODO: use only one tool to lint yaml files
"yml/no-empty-mapping-value": "off"
}
},
{
files: ["**/*.mdx"],
rules: {
Expand Down
File renamed without changes.
21 changes: 21 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
github_checks:
annotations: true

# Always comment on PRs, always create new comments
comment:
layout: "newheader, diff, flags, files"
require_changes: false # if true: only post the comment if coverage changes
require_base: false # [yes :: must have a base report to post]
require_head: true # [yes :: must have a head report to post]
show_carryforward_flags: true
show_critical_paths: true # new option to labeled critical files
hide_comment_details: true # collapse all the "detailed info" for the PR comment

# Require a minimum coverage for the codecov/project PR check
coverage:
status:
patch: off # yamllint disable-line rule:truthy
project:
default:
target: "75%" # overall project/ repo coverage
threshold: "1%"
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,11 @@
"lint:package-json": "publint",
"lint:prettier": "prettier --config=.prettierrc.cjs --check .",
"lint:prettier:fix": "prettier --config=.prettierrc.cjs --write .",
"lint:secrets": "secretlint **/*",
"lint:staged": "lint-staged --verbose --concurrent false --debug",
"lint:text": "textlint ./.github/ ./README.md ./UPGRADE.md --parallel --experimental --cache --dry-run",
"lint:text:fix": "textlint ./.github/ ./README.md ./UPGRADE.md --parallel --experimental --fix",
"lint:types": "tsc --noEmit",
"prepare": "is-ci || (node verify-node-version.cjs && pnpx only-allow pnpm && husky)",
"run:example": "cd example && pnpm exec vite build",
"sort-package-json": "sort-package-json ./package.json examples/**/package.json",
Expand Down
4 changes: 2 additions & 2 deletions src/core/utils/find-html-webpack-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Module from "node:module";

import type { Compilation as RspackCompilation } from "@rspack/core";
import type HtmlWebpackPlugin from "html-webpack-plugin";
import type { Compilation as WebpackCompilation } from "webpack";
import type { Compilation as WebpackCompilation, WebpackError } from "webpack";

const require = Module.createRequire(import.meta.url);

Expand Down Expand Up @@ -38,7 +38,7 @@ const findHtmlWebpackPlugin = (compilation: RspackCompilation | WebpackCompilati
"This @anolilab/unplugin-favicons version is not compatible with your current HtmlWebpackPlugin version.\n" +
"Please upgrade to HtmlWebpackPlugin >= 5\n"
}${getHtmlWebpackPluginVersion()}`,
),
) as WebpackError,
);

return undefined;
Expand Down

0 comments on commit aeb4a3c

Please sign in to comment.