Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ANSIBLE_METADATA #339

Merged

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Remove ANSIBLE_METADATA

ISSUE TYPE
  • Docs Pull Request

@Andersson007 Andersson007 changed the title [WIP] Remove ANSIBLE_METADATA Remove ANSIBLE_METADATA May 14, 2020
@ansibullbot
Copy link
Collaborator

@Andersson007 This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibullbot ansibullbot added affects_2.10 needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels May 14, 2020
@martinm82
Copy link
Contributor

Is the ANSIBLE_METADATA not required anymore? Do you have a link to a documentation of what we need to take into account when writing new modules/plugins? I have an open PR for a new module and probably would need to clean it up as it was created based on rules from Ansible 2.7

@gundalow
Copy link
Contributor

gundalow commented May 14, 2020

Is the ANSIBLE_METADATA not required anymore? Do you have a link to a documentation of what we need to take into account when writing new modules/plugins? I have an open PR for a new module and probably would need to clean it up as it was created based on rules from Ansible 2.7

@martinm82 ansible-collections/overview#45 (comment)
May I suggest subscribing (button on the right hand side) to ansible-collections/overview#45 and ansible/community#346 this is a good way to keep in the loop about potential changes.

@Andersson007
Copy link
Contributor Author

ready_for_review

@Andersson007
Copy link
Contributor Author

ansible/community#346

@Andersson007
Copy link
Contributor Author

CC @gundalow @felixfontein

@Andersson007
Copy link
Contributor Author

sorry, guys, i thought it's only for modules. Now i grepped through the whole content. When CI passed, it's ready for review

@Andersson007
Copy link
Contributor Author

@gundalow
Copy link
Contributor

gundalow commented May 14, 2020

Is the ANSIBLE_METADATA not required anymore? Do you have a link to a documentation of what we need to take into account when writing new modules/plugins? I have an open PR for a new module and probably would need to clean it up as it was created based on rules from Ansible 2.7

@martinm82 ansible-collections/overview#45 (comment)
May I suggest subscribing (button on the right hand side) to ansible-collections/overview#45 and ansible/community#346 this is a good way to keep in the loop about potential changes.

Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Felix reviewed to etc3, I reviewed the rest.
Thanks for doing this!

@gundalow gundalow merged commit 5d226f8 into ansible-collections:master May 14, 2020
@gundalow
Copy link
Contributor

@Andersson007 Thank you for doing this
@felixfontein @resmo Thank you for the careful reviews

@Andersson007
Copy link
Contributor Author

@gundalow @felixfontein @resmo thanks for reviewing and merging

@felixfontein
Copy link
Collaborator

felixfontein commented May 14, 2020

If we ever need this, here's a list of modules which were marked as stableinterface:

cloud/digital_ocean/digital_ocean_domain.py
database/proxysql/proxysql_replication_hostgroups.py
database/proxysql/proxysql_mysql_users.py
database/proxysql/proxysql_global_variables.py
database/proxysql/proxysql_backend_servers.py
database/proxysql/proxysql_query_rules.py
database/proxysql/proxysql_scheduler.py
database/proxysql/proxysql_manage_config.py
database/postgresql/postgresql_db.py
database/postgresql/postgresql_privs.py
database/postgresql/postgresql_user.py
files/xattr.py
notification/bearychat.py
notification/osx_say.py
notification/slack.py
notification/say.py
notification/irc.py
notification/mail.py
notification/jabber.py
notification/cisco_spark.py
notification/hipchat.py
packaging/os/pkgutil.py
packaging/os/apk.py
system/interfaces_file.py
system/runit.py
system/svc.py
system/osx_defaults.py
system/awall.py
system/puppet.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants