add better error message for missing datastore #2103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If you try to add a datastore that does not exist to the allowed datastores list in the vCLS config, you get a cryptic error message. If a user encounters the error, its really not clear what went wrong.
This change adds a more descriptive error message in the case that the datastore a user tries to add cannot be found.
I deconstructed the existing method a bit as well, since it was beginning to get large and complex.
ISSUE TYPE
COMPONENT NAME
vmware_cluster_vcls
ADDITIONAL INFORMATION
Test Playbook:
Before:
After: