Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Including files in source distributions with MANIFEST.in #156

Merged
merged 1 commit into from
Jun 6, 2023
Merged

enhancement: Including files in source distributions with MANIFEST.in #156

merged 1 commit into from
Jun 6, 2023

Conversation

hswong3i
Copy link
Contributor

When packaging as .deb/.rpm with setuptools (sometime without setuptools_scm), some required template files are excluded from the final packaging result, unless specify them within MANIFEST.in.

See https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html
See https://packaging.python.org/en/latest/guides/using-manifest-in

hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request May 18, 2023
@hswong3i
alvistack/v23.0.0
7f21305 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.0.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.0.0-1.spec
    mv ../python*-molecule-plugins*23.0.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.0.0
    rm -rf ../python*-molecule-plugins*23.0.0*.*

See ansible-community#155
See ansible-community#156

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request May 18, 2023
@hswong3i
alvistack/v23.4.0
05ab927 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.4.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.4.0-1.spec
    mv ../python*-molecule-plugins*23.4.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.4.0
    rm -rf ../python*-molecule-plugins*23.4.0*.*

See ansible-community#142
See ansible-community#155
See ansible-community#156

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request May 18, 2023
@hswong3i
alvistack/v23.4.1
12a77cc 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.4.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.4.1-1.spec
    mv ../python*-molecule-plugins*23.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.4.1
    rm -rf ../python*-molecule-plugins*23.4.1*.*

See ansible-community#142
See ansible-community#155
See ansible-community#156

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request May 18, 2023
@hswong3i
alvistack/v23.4.0
9f30f4e 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.4.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.4.0-1.spec
    mv ../python*-molecule-plugins*23.4.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.4.0
    rm -rf ../python*-molecule-plugins*23.4.0*.*

See ansible-community#142
See ansible-community#155
See ansible-community#156

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request May 18, 2023
@hswong3i
alvistack/v23.4.1
1ca8c96 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.4.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.4.1-1.spec
    mv ../python*-molecule-plugins*23.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.4.1
    rm -rf ../python*-molecule-plugins*23.4.1*.*

See ansible-community#142
See ansible-community#155
See ansible-community#156

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@hswong3i hswong3i changed the title [PATCH] Including files in source distributions with MANIFEST.in enhancement: Including files in source distributions with MANIFEST.in May 18, 2023
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request May 18, 2023
@hswong3i
alvistack/v23.4.0
d27232b 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.4.0.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.4.0-1.spec
    mv ../python*-molecule-plugins*23.4.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.4.0
    rm -rf ../python*-molecule-plugins*23.4.0*.*

See ansible-community#142
See ansible-community#155
See ansible-community#156

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/ansible-community-molecule-plugins that referenced this pull request May 18, 2023
@hswong3i
alvistack/v23.4.1
e2ae390 
    git clean -xdf
    tar zcvf ../python-molecule-plugins_23.4.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-molecule-plugins.spec ../python-molecule-plugins_23.4.1-1.spec
    mv ../python*-molecule-plugins*23.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.4.1
    rm -rf ../python*-molecule-plugins*23.4.1*.*

See ansible-community#142
See ansible-community#155
See ansible-community#156

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@apatard apatard added the enhancement New feature or request label May 31, 2023
@apatard
Copy link
Member

apatard commented May 31, 2023

Can you rebase your PR please ?

@hswong3i
[PATCH] Including files in source distributions with MANIFEST.in
8a89e7a 
When packaging as .deb/.rpm with setuptools (sometime without
setuptools_scm), some required template files are excluded from the
final packaging result, unless specify them within `MANIFEST.in`.

See https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html
See https://packaging.python.org/en/latest/guides/using-manifest-in

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@hswong3i
Copy link
Contributor Author

hswong3i commented Jun 6, 2023

Can you rebase your PR please ?

Done ;-)

@apatard
Copy link
Member

apatard commented Jun 6, 2023

Can you rebase your PR please ?

Done ;-)

Thanks. Merging now.

@apatard apatard merged commit 0de8ad0 into ansible-community:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apatard apatard apatard approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hswong3i @apatard