chore: update ui port for development environments #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Sep 21, 2023
Alex-Izquierdo
force-pushed
the
fix-ui-port
branch
from
dd8ab26
to
bacb0ec
Compare
bzwei
previously approved these changes
Sep 21, 2023
|
tested docker-compose on mac |
bzwei
reviewed
Sep 21, 2023
mkanoor
previously approved these changes
Sep 21, 2023
|
Tested with With the latest fedora podman is broken |
bzwei
reviewed
Sep 21, 2023
|
Verified on podman 4.6.2-1.
@mkanoor you can downgrade the |
ttuffin
approved these changes
Sep 22, 2023
bzwei
approved these changes
Sep 22, 2023
Dostonbek1
pushed a commit
to Dostonbek1/eda-server
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Bill Wei <bilwei@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #412
We added the new envvar, but it requires to change as well the default port. Now the UI image listens by default at the https default port (443) and is mapped to 8443 (by default system doesn't allow to map ports under 1024)