Example for #67 - Route 53 Example #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmbuckley
reviewed
Jun 21, 2023
| type = "CNAME" | ||
| records = ["www.example.com"] | ||
| } | ||
| something_interesting = { |
There was a problem hiding this comment.
I may be being picky, but I would say put the TXT example on the canonical records rather than in the alias, and a lot of TXT records tend to be applied to the apex domain, but you could give an example like google-site-verification for instance (see answerdigital.com)
There was a problem hiding this comment.
See latest commit
cmbuckley
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Never applied this as there's nowt to check.
However will allow for this to be automated for #65