fix: Update the tox.ini to different tox env

[Revathyvenugopal162]

No description provided.

[ansys-reviewer-bot]

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (ba66041) to head (1adab82).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
- Coverage   87.44%   87.36%   -0.09%     
==========================================
  Files          55       55              
  Lines        9845     9923      +78     
==========================================
+ Hits         8609     8669      +60     
- Misses       1236     1254      +18     

[jorgepiloto]

This is going in the right direction, thanks @Revathyvenugopal162.

[jorgepiloto]

Thanks for the heads up, @germa89.

We should take advantage of this and add a rule for building a docker image locally. This will help us to review the docker/ directory and the current image building process.

This directory could look like this:

docker/
|- linux/
   |- Dockerfile
   |- docker-compose.yml
   |- distributions/
      |- .gitignore  # Ignore everything except the dir itself
      |- .gitkeep

Users should just copy MAPDL artifacts in the distributions/ dir. Then, running:

tox -e docker-build-images would trigger the docker-compose.yml file.

[germa89]

Building the docker image is a bit complex.. because the dockerignore depends on the MAPDL version.
The docker directory is not used by the CICD nor myself to build the docker image at the moment, hence it is not fully maintained.
We have some instructions about building the docker image in: https://mapdl.docs.pyansys.com/version/stable/getting_started/make_container.html

We could meet next week to discuss this more in details.

[wiz-inc-572fc38784]

Wiz Scan Summary

IaC Misconfigurations
Vulnerabilities
Sensitive Data
Total
Secrets

[jorgepiloto]

This line is explicit. No need for a comment.

Suggested change

# Use Ubuntu 22.04 as the base image

[jorgepiloto]

Remove only the right files in the tmp/ dir. There may be files in this directory used by other running processes.

[jorgepiloto]

Is this a variable linked to a unified install? Should it be AWP_ROOT241?

[germa89]

it is.

[jorgepiloto]

Login is no longer required since users can build the images locally:

Suggested change

docker login ghcr.io -u {env:GITHUB_USERNAME} -p {env:GITHUB_TOKEN}

[jorgepiloto]

Suggested change

	{env:MAPDL_DOCKER_REGISTRY_URL} -smp
	-smp

[germa89]

@jorgepiloto @Revathyvenugopal162 how are we doing with this? :)

[Revathyvenugopal162]

@jorgepiloto @Revathyvenugopal162 how are we doing with this? :)

Sorry for the delay, I was tied up with the theme reformatting. I’ll dive into this PR next week, fix the issue, and keep you updated on the progress.

[github-actions]

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry. You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓