Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting ´´to_dataframe()´´ for some bc list commands #3412

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

pvargasm
Copy link
Collaborator

Description

to_dataframe() support for the output of following list boundary conditions commands: DKLIST, DLLIST, DALIST, FKLIST, SFLLIST, BFKLIST, BFLLIST and BFALIST

Issue linked

N / A

Checklist

@pvargasm pvargasm requested a review from a team as a code owner September 17, 2024 10:21
@pvargasm pvargasm requested review from germa89 and clatapie and removed request for a team September 17, 2024 10:21
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 enabled auto-merge (squash) September 17, 2024 10:23
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.36%. Comparing base (1b82d34) to head (54d9fd1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3412      +/-   ##
==========================================
- Coverage   85.13%   83.36%   -1.78%     
==========================================
  Files          55       55              
  Lines        9925     9963      +38     
==========================================
- Hits         8450     8306     -144     
- Misses       1475     1657     +182     

@clatapie clatapie changed the title to_dataframe() support for some bc list commands feat: supporting ´´to_dataframe()´´ for some bc list commands Sep 17, 2024
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Sep 17, 2024
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! However it seems that the coverage percentage is not high enough to pass. Ideally, you should add additional unit tests to check all the possible cases.
Pinging @germa89 for visibility.

@germa89 germa89 merged commit 1995d96 into main Sep 17, 2024
42 of 43 checks passed
@germa89 germa89 deleted the feat/bc_list2dataframe branch September 17, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants