Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The js rule options were ignored when mapping to ts #609

Closed
7 tasks done
lvjiaxuan opened this issue Sep 14, 2024 · 1 comment · Fixed by #610
Closed
7 tasks done

The js rule options were ignored when mapping to ts #609

lvjiaxuan opened this issue Sep 14, 2024 · 1 comment · Fixed by #610

Comments

@lvjiaxuan
Copy link
Contributor

Describe the bug

js rule with options:
image

ts rule without options:
image

I have found 2 such rules, if im not mistaken:
image

Reproduction

This repo itself.

System Info

System:
    OS: Windows 10 10.0.17763
    CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
    Memory: 8.12 GB / 15.81 GB
  Binaries:
    Node: 20.15.1 - d:\nvm\nodejs\node.EXE
    Yarn: 1.22.19 - d:\nvm\nodejs\yarn.CMD
    npm: 10.7.0 - d:\nvm\nodejs\npm.CMD
    pnpm: 9.10.0 - d:\nvm\nodejs\pnpm.CMD
    bun: 1.1.7 - ~\.bun\bin\bun.EXE
  Browsers:
    Chrome: 128.0.6613.138
    Internet Explorer: 11.0.17763.2989

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@antfu
Copy link
Owner

antfu commented Sep 14, 2024

Oh I see. PR welcome! Thank you

lvjiaxuan added a commit to lvjiaxuan/eslint-config-1 that referenced this issue Sep 15, 2024
@antfu antfu closed this as completed in 207634c Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants