Skip to content

Commit

Permalink
Fix broken Markdown links check (#3671)
Browse files Browse the repository at this point in the history
`check-modified-files-only` can only be used for pull_request events (as
per the documentation for the action), and `github.base_ref` is not set
for push events.

At the moment the Github job is failing because it is run for push
events on the main and release branches.

Signed-off-by: Antonin Bas <abas@vmware.com>
  • Loading branch information
antoninbas committed Apr 20, 2022
1 parent a566009 commit 0668185
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ jobs:
- name: Run verify scripts
run: make verify
- name: Checking for broken Markdown links
if: ${{ github.event_name == 'pull_request' }}
uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
# Check modified files only for pull requests. Cronjob "Verify docs" takes care of checking all markdown files.
Expand Down

0 comments on commit 0668185

Please sign in to comment.