-
Notifications
You must be signed in to change notification settings - Fork 363
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add 'antctl get bgppolicy' command (#6646)
Add `antctl get bgppolicy` agent command to get effective BGP policy applied on the Node. The command is implemented using a new HTTP endpoint (`/bgppolicy`), which will return a `404 Not Found` error if no BGPPolicy has been applied on the Node. For #6209 Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
- Loading branch information
Showing
19 changed files
with
423 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright 2024 Antrea Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package bgppolicy | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "net/http" | ||
| "reflect" | ||
|
|
||
| "k8s.io/klog/v2" | ||
|
|
||
| "antrea.io/antrea/pkg/agent/apis" | ||
| "antrea.io/antrea/pkg/querier" | ||
| ) | ||
|
|
||
| // HandleFunc returns the function which can handle queries issued by the bgppolicy command. | ||
| func HandleFunc(bq querier.AgentBGPPolicyInfoQuerier) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, r *http.Request) { | ||
| if bq == nil || reflect.ValueOf(bq).IsNil() { | ||
| // The error message must match the "FOO is not enabled" pattern to pass antctl e2e tests. | ||
| http.Error(w, "bgp is not enabled", http.StatusServiceUnavailable) | ||
| return | ||
| } | ||
|
|
||
| bgpPolicyName, routerID, localASN, listenPort := bq.GetBGPPolicyInfo() | ||
| bgpPolicyResp := apis.BGPPolicyResponse{ | ||
| BGPPolicyName: bgpPolicyName, | ||
| RouterID: routerID, | ||
| LocalASN: localASN, | ||
| ListenPort: listenPort, | ||
| } | ||
| if bgpPolicyName == "" { | ||
| http.Error(w, "there is no effective bgp policy applied to the Node", http.StatusNotFound) | ||
| return | ||
| } | ||
|
|
||
| if err := json.NewEncoder(w).Encode(bgpPolicyResp); err != nil { | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| klog.ErrorS(err, "Error when encoding BGPPolicyResp to json") | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // Copyright 2024 Antrea Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package bgppolicy | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| "go.uber.org/mock/gomock" | ||
|
|
||
| "antrea.io/antrea/pkg/agent/apis" | ||
| queriertest "antrea.io/antrea/pkg/querier/testing" | ||
| ) | ||
|
|
||
| func TestBGPPolicyQuery(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| expectedStatus int | ||
| expectedResponse apis.BGPPolicyResponse | ||
| }{ | ||
| { | ||
| name: "bgpPolicyState exists", | ||
| expectedStatus: http.StatusOK, | ||
| expectedResponse: apis.BGPPolicyResponse{ | ||
| BGPPolicyName: "policy-1", | ||
| RouterID: "192.168.1.2", | ||
| LocalASN: 65000, | ||
| ListenPort: 179, | ||
| }, | ||
| }, | ||
| { | ||
| name: "bgpPolicyState does not exist", | ||
| expectedStatus: http.StatusNotFound, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| ctrl := gomock.NewController(t) | ||
| q := queriertest.NewMockAgentBGPPolicyInfoQuerier(ctrl) | ||
| q.EXPECT().GetBGPPolicyInfo().Return(tt.expectedResponse.BGPPolicyName, tt.expectedResponse.RouterID, | ||
| tt.expectedResponse.LocalASN, tt.expectedResponse.ListenPort) | ||
| handler := HandleFunc(q) | ||
|
|
||
| req, err := http.NewRequest(http.MethodGet, "", nil) | ||
| require.NoError(t, err) | ||
|
|
||
| recorder := httptest.NewRecorder() | ||
| handler.ServeHTTP(recorder, req) | ||
| assert.Equal(t, tt.expectedStatus, recorder.Code) | ||
|
|
||
| if tt.expectedStatus == http.StatusOK { | ||
| var received apis.BGPPolicyResponse | ||
| err = json.Unmarshal(recorder.Body.Bytes(), &received) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, tt.expectedResponse, received) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.