-
Notifications
You must be signed in to change notification settings - Fork 363
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix log spam when there is any DNS based LoadBalancer Service (#4234)
IP in Service.Status.LoadBalancer.Ingress is optional and may be not set for load-balancer ingress points that are DNS based. It should check if the IP is empty before appending it to the slice, otherwise every round of sync will produce one error log "Skipping invalid IP:" for each IP, leading to log spam. The same issue has been fixed in K8s upstream by kubernetes/kubernetes#101690. Signed-off-by: Quan Tian <qtian@vmware.com>
- Loading branch information
Showing
1 changed file
with
13 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters