Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add informers for AntreaAgentInfos and AntreaControllerInfos #1609

Closed
liu4480 opened this issue Dec 3, 2020 · 5 comments
Closed

add informers for AntreaAgentInfos and AntreaControllerInfos #1609

liu4480 opened this issue Dec 3, 2020 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@liu4480
Copy link
Contributor

liu4480 commented Dec 3, 2020

Describe the problem/challenge you have
I want to monitor AntreaAgentInfos and AntreaControllerInfos to get information about these resources, watch function is not enough since I need to wrap the add/update/delete functions

Describe the solution you'd like
add informer for the two resources

Anything else you would like to add?

@liu4480 liu4480 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 3, 2020
@tnqn
Copy link
Member

tnqn commented Dec 3, 2020

Since this is Antrea resources and we already have its clientset code in the repo, I think harmless to generate the informer in the repo for consuming in case each downstream will have to maintain its own copy, even though Antrea itself doesn't use it yet.
@jianjuns @antoninbas do you agree?

@jianjuns
Copy link
Contributor

jianjuns commented Dec 3, 2020

Makes sense to me.

@mengdie-song
Copy link
Contributor

Same here, we can generate both informers and listers for AntreaAgentInfos and AntreaControllerInfos, so that others can interact with monitoring CRDs without having to generate informers and listers themselves.

@tnqn
Copy link
Member

tnqn commented Dec 4, 2020

Thanks @jianjuns @mengdie-song for your inputs.

@liu4480 would you mind creating a PR to add the code you need?

@tnqn
Copy link
Member

tnqn commented Dec 4, 2020

Closed by #1612

@tnqn tnqn closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants