-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listers and informers for antreaagentinfo and antreacontrollerinfo #1612
Conversation
Thanks for your PR. The following commands are available:
|
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
+ Coverage 63.31% 64.31% +0.99%
==========================================
Files 170 181 +11
Lines 14250 15344 +1094
==========================================
+ Hits 9023 9868 +845
- Misses 4292 4455 +163
- Partials 935 1021 +86
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. It would be better to enhance PR description and the commit message with the related issue, e.g. Fixes: #1609
…llerinfo this is related to issue#1609, add listers and informers for crds, in case that each downstream maintain a lister and informer
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…llerinfo (#1612) this is related to issue#1609, add listers and informers for crds, in case that each downstream maintain a lister and informer
this is related to #1609, add listers and informers for crds, in case that each downstream maintain a lister and informer