Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listers and informers for antreaagentinfo and antreacontrollerinfo #1612

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add listers and informers for antreaagentinfo and antreacontrollerinfo #1612

merged 1 commit into from
Dec 4, 2020

Conversation

liu4480
Copy link
Contributor

@liu4480 liu4480 commented Dec 4, 2020

this is related to #1609, add listers and informers for crds, in case that each downstream maintain a lister and informer

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
  • /skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@liu4480 liu4480 closed this Dec 4, 2020
@liu4480 liu4480 reopened this Dec 4, 2020
@liu4480 liu4480 requested review from Dyanngg, gran-vmv and mengdie-song and removed request for gran-vmv December 4, 2020 09:12
@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #1612 (c32c0f1) into master (9d3d10b) will increase coverage by 0.99%.
The diff coverage is 58.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
+ Coverage   63.31%   64.31%   +0.99%     
==========================================
  Files         170      181      +11     
  Lines       14250    15344    +1094     
==========================================
+ Hits         9023     9868     +845     
- Misses       4292     4455     +163     
- Partials      935     1021      +86     
Flag Coverage Δ
e2e-tests 47.70% <38.16%> (?)
kind-e2e-tests 52.05% <52.43%> (-3.34%) ⬇️
unit-tests 40.45% <19.59%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/antrea-agent/agent.go 0.00% <0.00%> (ø)
cmd/antrea-agent/options.go 21.69% <0.00%> (+0.97%) ⬆️
.../agent/apiserver/handlers/networkpolicy/handler.go 58.33% <ø> (ø)
...gent/controller/noderoute/node_route_controller.go 61.04% <ø> (+14.58%) ⬆️
pkg/agent/stats/collector.go 97.72% <ø> (ø)
pkg/antctl/antctl.go 100.00% <ø> (ø)
pkg/antctl/transform/controllerinfo/transform.go 0.00% <ø> (ø)
pkg/antctl/transform/version/transform.go 0.00% <ø> (ø)
pkg/controller/networkpolicy/tier.go 90.00% <ø> (ø)
pkg/features/antrea_features.go 16.66% <ø> (ø)
... and 93 more

Copy link
Contributor

@mengdie-song mengdie-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. It would be better to enhance PR description and the commit message with the related issue, e.g. Fixes: #1609

@liu4480 liu4480 changed the title add listers and informers for antreaagentinfo and antreacontrollerinfo Fixes: add listers and informers for antreaagentinfo and antreacontrollerinfo Dec 4, 2020
…llerinfo

this is related to issue#1609, add listers and informers for crds,
in case that each downstream maintain a lister and informer
@liu4480
Copy link
Contributor Author

liu4480 commented Dec 4, 2020

/test-all

@mengdie-song mengdie-song changed the title Fixes: add listers and informers for antreaagentinfo and antreacontrollerinfo Add listers and informers for antreaagentinfo and antreacontrollerinfo Dec 4, 2020
Copy link
Contributor

@mengdie-song mengdie-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn merged commit 235f97c into antrea-io:master Dec 4, 2020
@liu4480 liu4480 deleted the crd-lister-informer branch December 18, 2020 03:54
antoninbas pushed a commit that referenced this pull request Dec 23, 2020
…llerinfo (#1612)

this is related to issue#1609, add listers and informers for crds,
in case that each downstream maintain a lister and informer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants