Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace actions/upload-release-asset with a maintained Github action #4514

Closed
antoninbas opened this issue Dec 23, 2022 · 0 comments · Fixed by #4638
Closed

Replace actions/upload-release-asset with a maintained Github action #4514

antoninbas opened this issue Dec 23, 2022 · 0 comments · Fixed by #4638
Assignees
@antoninbas
Labels
kind/task Categorizes issue or PR as related to a routine task that needs to be performed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@antoninbas
Copy link
Contributor

The action actions/upload-release-asset is no longer maintained, and has not been updated in a while. The Github repository has been archived: https://github.com/actions/upload-release-asset

We should find an alternative community action to replace it with.
@antoninbas antoninbas added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/task Categorizes issue or PR as related to a routine task that needs to be performed labels Dec 23, 2022
@antoninbas antoninbas self-assigned this Feb 17, 2023
antoninbas added a commit to antoninbas/antrea that referenced this issue Feb 17, 2023
@antoninbas
Use new Github Action to upload release assets
f6188f1 
Use alexellis/upload-assets instead of actions/upload-release-asset,
which is no longer maintained. One advantage is that we can list all
assets with a glob expression, so the workflow file is much less
verbose.

We also do a minor change to ./hack/generate-manifest-windows.sh, so
that it can be run on macOS (one of the sed commands was GNU-specific,
and there is no reason to use sed instead of kustomize).

Fixes antrea-io#4514

Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue Feb 17, 2023
@antoninbas
Use new Github Action to upload release assets
43231e3 
Use alexellis/upload-assets instead of actions/upload-release-asset,
which is no longer maintained. One advantage is that we can list all
assets with a glob expression, so the workflow file is much less
verbose.

We also do a minor change to ./hack/generate-manifest-windows.sh, so
that it can be run on macOS (one of the sed commands was GNU-specific,
and there is no reason to use sed instead of kustomize).

Fixes antrea-io#4514

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas mentioned this issue Feb 17, 2023
Merged
antoninbas added a commit that referenced this issue Feb 20, 2023
@antoninbas
Use new Github Action to upload release assets (#4638)
9b860d8 
Use alexellis/upload-assets instead of actions/upload-release-asset,
which is no longer maintained. One advantage is that we can list all
assets with a glob expression, so the workflow file is much less
verbose.

We also do a minor change to ./hack/generate-manifest-windows.sh, so
that it can be run on macOS (one of the sed commands was GNU-specific,
and there is no reason to use sed instead of kustomize).

Fixes #4514

Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
kind/task Categorizes issue or PR as related to a routine task that needs to be performed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new Github Action to upload release assets antoninbas/antrea
1 participant
@antoninbas