Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Traceflow API v1beta1 in antctl traceflow #5656

Closed
Atish-iaf opened this issue Nov 2, 2023 · 2 comments · Fixed by #5689
Closed

Use Traceflow API v1beta1 in antctl traceflow #5656

Atish-iaf opened this issue Nov 2, 2023 · 2 comments · Fixed by #5689
Assignees
@rajnkamr @Atish-iaf
Labels
area/ops/traceflow Issues or PRs related to the Traceflow feature kind/bug Categorizes issue or PR as related to a bug.
Milestone
Antrea v1.15 release

Comments

@Atish-iaf
Copy link
Contributor

Describe the bug
Traceflow API has been promoted to v1beta1 but in antctl traceflow it still uses v1alpha1

To Reproduce

Expected
antctl traceflow should use Traceflow API v1beta1

Actual behavior
antctl traceflow uses Traceflow API v1alpha1

Versions:

Additional context
https://github.com/antrea-io/antrea/blob/main/pkg/antctl/raw/traceflow/command.go
@Atish-iaf Atish-iaf added the kind/bug Categorizes issue or PR as related to a bug. label Nov 2, 2023
@rajnkamr rajnkamr added this to the Antrea v1.15 release milestone Nov 2, 2023
@rajnkamr rajnkamr added the area/ops/traceflow Issues or PRs related to the Traceflow feature label Nov 2, 2023
@luolanzone
Copy link
Contributor

Please help to check and move other dependent types like Packet, Header etc to v1beta1 as well. Thanks.

@rajnkamr
Copy link
Contributor

rajnkamr commented Nov 9, 2023 •
edited
Loading

Would prefer to raise another PR for transition required for additional fields to v1beta1

@rajnkamr rajnkamr mentioned this issue Nov 9, 2023
Merged
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Nov 9, 2023
@Atish-iaf
Use Traceflow API v1beta1 in antctl traceflow
c600c26 
Fixes antrea-io#5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
@Atish-iaf Atish-iaf mentioned this issue Nov 9, 2023
Merged
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Nov 9, 2023
@Atish-iaf
Use Traceflow API v1beta1 in antctl traceflow
d5f88aa 
Fixes antrea-io#5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Nov 14, 2023
@Atish-iaf
Use Traceflow API v1beta1
f87b4ca 
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.

Fixes antrea-io#5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
antoninbas pushed a commit that referenced this issue Nov 15, 2023
@Atish-iaf
Use Traceflow API v1beta1 (#5689)
aa1c6b0 
Use Traceflow API v1beta1 for `antctl traceflow` and in Traceflow e2e tests.

Fixes #5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Nov 16, 2023
@Atish-iaf
Use Traceflow API v1beta1
a854f96 
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.

Fixes antrea-io#5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Nov 16, 2023
@Atish-iaf
Use Traceflow API v1beta1
fefbdc6 
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.

Fixes antrea-io#5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
antoninbas pushed a commit that referenced this issue Nov 17, 2023
@Atish-iaf
Use Traceflow API v1beta1 (#5713)
e144059 
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.

Fixes #5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
antoninbas pushed a commit that referenced this issue Nov 17, 2023
@Atish-iaf
Use Traceflow API v1beta1 (#5714)
40bafb3 
Update traceflow api to v1beta1 in antctl traceflow and traceflow e2e tests.

Fixes #5656

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajnkamr rajnkamr

@Atish-iaf Atish-iaf

Labels
area/ops/traceflow Issues or PRs related to the Traceflow feature kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
Antrea v1.15 release
Development

Successfully merging a pull request may close this issue.

Use Traceflow API v1beta1 Atish-iaf/antrea
3 participants
@rajnkamr @Atish-iaf @luolanzone