Switch CRD apiVersion to v1 from v1beta1 #1009

abhiraut · 2020-07-31T00:59:46Z

apiVersion v1beta1 has been deprecated for CRDs in favor of v1.
This PR takes care of updating versions of all the CRDs available.
In addition to the version update, this PR also ensures strict schema validation for the following CRDs:

traceflow
clusternetworkpolicy
networkpolicy
externalentity
tier

Related-Issue: #684

antrea-bot · 2020-07-31T01:00:03Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

abhiraut · 2020-07-31T01:30:36Z

/test-all

abhiraut · 2020-07-31T01:31:58Z

reopening the old PR.. by mistake renamed the branch and created a new one instead. closed the original PR #508

abhiraut · 2020-07-31T01:33:10Z

build/yamls/base/crds.yml

+      schema:
+        openAPIV3Schema:
+          type: object
+          x-kubernetes-preserve-unknown-fields: true


this ensures original behavior. but imo we should update them to perform strict validation in a follow up for individual CRDs

abhiraut · 2020-07-31T18:41:03Z

/test-all

antoninbas

"apiextensions.k8s.io/v1beta1" is deprecated in 1.19 but will not be removed until 1.22 (kubernetes/kubernetes#82022)

Unless the default K8s version for managed services for which we claim support (GKE, EKS) is updated before we release Antrea v0.9.0, I do not think we should merge this. In GKE, it seems the default K8s version is currently 1.15.12. In EKS, it seems that the default version is 1.17 (but 1.15 is still supported). So for Antrea v0.9.0, I believe we should target K8s 1.15 -> 1.19, and postpone merging this PR for v0.10.0.

This PR should also reference this issue: #684

antoninbas · 2020-09-18T00:30:43Z

@abhiraut if you want to make that change for Antrea v0.10, it's ok with me. I see that the GKE stable channel is still using 1.15, but the regular channel is using 1.16.

abhiraut · 2020-09-18T17:40:07Z

@abhiraut if you want to make that change for Antrea v0.10, it's ok with me. I see that the GKE stable channel is still using 1.15, but the regular channel is using 1.16.

thanks.. will spin out a new PR sometime today

antrea-bot · 2020-09-18T23:38:56Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

codecov-commenter · 2020-09-18T23:42:49Z

Codecov Report

Merging #1009 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
+ Coverage   54.40%   54.49%   +0.08%     
==========================================
  Files         115      115              
  Lines       10807    10807              
==========================================
+ Hits         5880     5889       +9     
+ Misses       4353     4347       -6     
+ Partials      574      571       -3

Flag	Coverage Δ
#integration-tests	`44.98% <ø> (+0.03%)`	⬆️
#unit-tests	`41.55% <ø> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/ovs/openflow/ofctrl_bridge.go	`68.77% <0.00%> (+0.79%)`	⬆️
pkg/apiserver/storage/ram/watch.go	`88.46% <0.00%> (+3.84%)`	⬆️
pkg/apiserver/certificate/certificate.go	`77.63% <0.00%> (+6.57%)`	⬆️

abhiraut · 2020-09-18T23:53:16Z

/test-all

abhiraut · 2020-09-21T22:05:28Z

/test-networkpolicy

abhiraut · 2020-09-22T19:32:29Z

/skip-hw-offload

antoninbas

This LGTM, but let's get more reviews and ensure everyone is ok with this change, since it means we will not support K8s 1.16 any more

Besides that, any impact of adding OpenAPI validation schemas to the CRDs?

jianjuns · 2020-09-22T23:12:31Z

This LGTM, but let's get more reviews and ensure everyone is ok with this change, since it means we will not support K8s 1.16 any more

I think it is that we no longer support K8s 1.15?

antoninbas · 2020-09-22T23:14:36Z

Yes, that's a typo, we will no longer support 1.15, which is the K8s version used by GKE's "stable channel" (the "regular channel" uses 1.16).

tnqn

LGTM

abhiraut · 2020-09-23T18:03:23Z

This LGTM, but let's get more reviews and ensure everyone is ok with this change, since it means we will not support K8s 1.16 any more

Besides that, any impact of adding OpenAPI validation schemas to the CRDs?

I have added "x-kubernetes-preserve-unknown-fields: true" to the fields for CRDs which did not have schema defined before so that unknown fields are preserved. The other CRDs listed in PR description had schema which i translated to the new format.

antoninbas

LGTM

abhiraut · 2020-09-23T20:30:19Z

/test-all

tnqn

LGTM, one question inline

tnqn · 2020-09-24T16:25:39Z

build/yamls/base/crds.yml

@@ -27,6 +31,10 @@ spec:
    - name: v1beta1
      served: true
      storage: true
+      schema:


Is the a new field that is not present in v1beta1? want to check if a cluster that already uses antrea can upgrade to 0.10 by simply fixing apiextensions.k8s.io/v1beta1, or they need to fix all the CRD definition.

they do need to update the definition.. as there is some renaming "JSONPath -> jsonPath" and some fields no longer supported (preserveUnknownFields) and some fields have a different parent field (validation -> schema)

apiVersion v1beta1 has been deprecated for CRDs in favor of v1.

Signed-off-by: abhiraut <rauta@vmware.com>

abhiraut · 2020-09-24T20:18:26Z

/test-all

antoninbas

Approving again

vmwclabot added the cla-not-required label Jul 31, 2020

abhiraut changed the title ~~V1beta1~~ Switch CRD apiVersion to v1 from v1beta1 Jul 31, 2020

abhiraut requested review from salv-orlando, antoninbas and jianjuns July 31, 2020 01:27

abhiraut commented Jul 31, 2020

View reviewed changes

antoninbas reviewed Aug 3, 2020

View reviewed changes

abhiraut force-pushed the v1beta1 branch from bca48dc to 3c3b508 Compare September 18, 2020 23:38

abhiraut mentioned this pull request Sep 18, 2020

Handle deprecation of apiextensions.k8s.io/v1beta1 in K8s 1.19 #684

Closed

14 tasks

abhiraut requested a review from antoninbas September 22, 2020 01:01

antoninbas requested a review from tnqn September 22, 2020 22:04

antoninbas reviewed Sep 22, 2020

View reviewed changes

tnqn previously approved these changes Sep 23, 2020

View reviewed changes

antoninbas previously approved these changes Sep 23, 2020

View reviewed changes

antoninbas added this to the Antrea v0.10.0 release milestone Sep 23, 2020

abhiraut dismissed antoninbas’s stale review via a0dc1e8 September 23, 2020 19:47

abhiraut dismissed tnqn’s stale review via a0dc1e8 September 23, 2020 19:47

abhiraut force-pushed the v1beta1 branch from 3c3b508 to a0dc1e8 Compare September 23, 2020 19:47

tnqn previously approved these changes Sep 24, 2020

View reviewed changes

abhiraut added 8 commits September 24, 2020 19:09

Use apiVersion v1 for CRDs

c2f9c88

apiVersion v1beta1 has been deprecated for CRDs in favor of v1.

Update other crd yamls

664a59e

Update validation to schema

5d55cdb

Signed-off-by: abhiraut <rauta@vmware.com>

Run make manifest

5024ba3

Update field name from JSONPath to jsonPath

0efa11e

Resolve conflicts

2fd89f3

Add Tier CRD as v1

bbc2cf6

Rebase conflicts

fa8b020

abhiraut dismissed tnqn’s stale review via fa8b020 September 24, 2020 19:35

abhiraut force-pushed the v1beta1 branch from a0dc1e8 to fa8b020 Compare September 24, 2020 19:35

antoninbas approved these changes Sep 24, 2020

View reviewed changes

abhiraut merged commit 4c6ecd0 into antrea-io:master Sep 24, 2020

abhiraut deleted the v1beta1 branch September 24, 2020 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch CRD apiVersion to v1 from v1beta1 #1009

Switch CRD apiVersion to v1 from v1beta1 #1009

abhiraut commented Jul 31, 2020 •

edited

Loading

antrea-bot commented Jul 31, 2020

abhiraut commented Jul 31, 2020

abhiraut commented Jul 31, 2020

abhiraut Jul 31, 2020

abhiraut commented Jul 31, 2020

antoninbas left a comment

antoninbas commented Sep 18, 2020

abhiraut commented Sep 18, 2020

antrea-bot commented Sep 18, 2020

codecov-commenter commented Sep 18, 2020 •

edited

Loading

abhiraut commented Sep 18, 2020

abhiraut commented Sep 21, 2020

abhiraut commented Sep 22, 2020

antoninbas left a comment

jianjuns commented Sep 22, 2020

antoninbas commented Sep 22, 2020

tnqn left a comment

abhiraut commented Sep 23, 2020

antoninbas left a comment

abhiraut commented Sep 23, 2020

tnqn left a comment

tnqn Sep 24, 2020

abhiraut Sep 24, 2020

abhiraut commented Sep 24, 2020

antoninbas left a comment

Switch CRD apiVersion to v1 from v1beta1 #1009

Switch CRD apiVersion to v1 from v1beta1 #1009

Conversation

abhiraut commented Jul 31, 2020 • edited Loading

antrea-bot commented Jul 31, 2020

abhiraut commented Jul 31, 2020

abhiraut commented Jul 31, 2020

abhiraut Jul 31, 2020

Choose a reason for hiding this comment

abhiraut commented Jul 31, 2020

antoninbas left a comment

Choose a reason for hiding this comment

antoninbas commented Sep 18, 2020

abhiraut commented Sep 18, 2020

antrea-bot commented Sep 18, 2020

codecov-commenter commented Sep 18, 2020 • edited Loading

Codecov Report

abhiraut commented Sep 18, 2020

abhiraut commented Sep 21, 2020

abhiraut commented Sep 22, 2020

antoninbas left a comment

Choose a reason for hiding this comment

jianjuns commented Sep 22, 2020

antoninbas commented Sep 22, 2020

tnqn left a comment

Choose a reason for hiding this comment

abhiraut commented Sep 23, 2020

antoninbas left a comment

Choose a reason for hiding this comment

abhiraut commented Sep 23, 2020

tnqn left a comment

Choose a reason for hiding this comment

tnqn Sep 24, 2020

Choose a reason for hiding this comment

abhiraut Sep 24, 2020

Choose a reason for hiding this comment

abhiraut commented Sep 24, 2020

antoninbas left a comment

Choose a reason for hiding this comment

abhiraut commented Jul 31, 2020 •

edited

Loading

codecov-commenter commented Sep 18, 2020 •

edited

Loading