Enhancement in support bundle #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
|
|
/test-all |
wenyingd
force-pushed
the
issue_1144
branch
2 times, most recently
from
e630342
to
00602a5
Compare
wenyingd
changed the title
|
/test-all |
weiqiangt
previously approved these changes
Aug 27, 2020
jianjuns
reviewed
Aug 27, 2020
pkg/ovs/ovsctl/ofctl.go
Outdated
| if len(portItem) > 0 { | ||
| rawPortDescItems = append(rawPortDescItems, portItem) | ||
| } | ||
| portItem = make([]string, 0) |
There was a problem hiding this comment.
Is portItem = nil better here?
There was a problem hiding this comment.
Sure, I will change.
pkg/support/dump.go
Outdated
| for idx := range portsDesc { | ||
| portData[idx] = strings.Join(portsDesc[idx], "\n") | ||
| } | ||
| err = afero.WriteFile(d.fs, filepath.Join(basedir, "ovsports"), []byte(strings.Join(portData, "\n")), 0644) |
There was a problem hiding this comment.
Does it make sense to make a separate func for line 237 to 241?
Then you can do:
return d.writeFile("ovsports", portData)
There was a problem hiding this comment.
Make sense, I could try to change.
1. Add support to collect ovs/kubelet logs and host network info on Windows Node. 2. Add support to dump OpenFlow ports desc.
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
+ Coverage 56.13% 56.19% +0.06%
==========================================
Files 105 105
Lines 11528 11550 +22
==========================================
+ Hits 6471 6491 +20
- Misses 4489 4490 +1
- Partials 568 569 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-networkpolicy |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 22, 2020
1. Add support to collect ovs/kubelet logs and host network info on Windows Node. 2. Add support to dump OpenFlow ports desc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144