Fix invalid supportbundle temporary name

[weiqiangt]

In afero 1.2.2, the TempFile does not accept wildcard and thus the filename will
contain an asterisk. Windows does not allow filename to have an asterisk.

Fixes #1148.

[weiqiangt]

/test-all

[antoninbas]

@weiqiangt I feel like I am missing something. When I look at the documentation for afero.TempFile and at the implementation (https://github.com/spf13/afero/blob/64002605e424363ac9aeb8c945c6dbfc06bd0d62/ioutil.go#L178), it seems that it should work. Could you explain where the issue comes from?

Also in your commit message, you mean "asterisk", not "asteroid".

[weiqiangt]

@weiqiangt I feel like I am missing something. When I look at the documentation for afero.TempFile and at the implementation (https://github.com/spf13/afero/blob/64002605e424363ac9aeb8c945c6dbfc06bd0d62/ioutil.go#L178), it seems that it should work. Could you explain where the issue comes from?

Also in your commit message, you mean "asterisk", not "asteroid".

Yeah, you're right. But the afero we're using in Antrea is 1.2.2 which has the following implementation.

func TempFile(fs Fs, dir, prefix string) (f File, err error) {
	if dir == "" {
		dir = os.TempDir()
	}

	nconflict := 0
	for i := 0; i < 10000; i++ {
		name := filepath.Join(dir, prefix+nextSuffix())
		f, err = fs.OpenFile(name, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0600)
		if os.IsExist(err) {
			if nconflict++; nconflict > 10 {
				randmu.Lock()
				rand = reseed()
				randmu.Unlock()
			}
			continue
		}
		break
	}
	return
}

Now, we have two options to solve this issue, upgrade or edit like this PR. I would prefer the prior one.

Yes, asterisk 🤦‍♂️.

[antoninbas]

I also like the upgrade option

[antrea-bot]

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

• /test-e2e: to trigger e2e tests.
• /skip-e2e: to skip e2e tests.
• /test-conformance: to trigger conformance tests.
• /skip-conformance: to skip conformance tests.
• /test-whole-conformance: to trigger all conformance tests on linux.
• /skip-whole-conformance: to skip all conformance tests on linux.
• /test-networkpolicy: to trigger networkpolicy tests.
• /skip-networkpolicy: to skip networkpolicy tests.
• /test-windows-conformance: to trigger windows conformance tests.
• /skip-windows-conformance: to skip windows conformance tests.
• /test-windows-networkpolicy: to trigger windows networkpolicy tests.
• /skip-windows-networkpolicy: to skip windows networkpolicy tests.
• /test-hw-offload: to trigger ovs hardware offload test.
• /skip-hw-offload: to skip ovs hardware offload test.
• /test-all: to trigger all tests (except whole conformance).
• /skip-all: to skip all tests (except whole conformance).

[antoninbas]

LGTM

[weiqiangt]

/test-all